Spring Tool Suite
  1. Spring Tool Suite
  2. STS-2768

allow creation and usage of tc server instances outside of installation directory

    Details

    • Type: Improvement Improvement
    • Status: Resolved Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.9.2.RELEASE, 3.0.0.M3
    • Fix Version/s: 3.2.0.M1
    • Component/s: SERVER
    • Labels:

      Description

      At the moment the tc server integration for Eclipse allows you to create new tc server instances (or select an existing one) when setting up a new server in Eclipse. But this works only for instances in the installation directory of the tc server itself, you cannot create instances outside of this directory or select existing instances from a different directory.

      This needs to be improved to allow creation and selection of instances in arbitrary directories.

        Activity

        Hide
        Tomasz Zarna added a comment -

        Creating and running an external instance with batch scripts works just fine. For the record, here are the commands I used:

        ...\vfabric-tc-server-developer-2.8.0.RELEASE>tcruntime-instance.bat create test -i c:\temp
        
        ...\vfabric-tc-server-developer-2.8.0.RELEASE>tcruntime-ctl.bat test batch -n c:\temp\
        

        The latter has to be run with admin rights when on Windows.

        Show
        Tomasz Zarna added a comment - Creating and running an external instance with batch scripts works just fine. For the record, here are the commands I used: ...\vfabric-tc-server-developer-2.8.0.RELEASE>tcruntime-instance.bat create test -i c:\temp ...\vfabric-tc-server-developer-2.8.0.RELEASE>tcruntime-ctl.bat test batch -n c:\temp\ The latter has to be run with admin rights when on Windows.
        Hide
        Tomasz Zarna added a comment -

        Here is a work-in-progress commit:
        + Allow to select an external location for a newly create instance (uncheck Use default instance location on the Create tc Server Instance page).
        + Added UI test for the New Server Wizard.
        + Added a simple test called TcServerInstanceTest for executing instance creating with a instance dir provided.
        +/- No validation of a created server (e.g. if it runs) in the UI test. All assertions are about the wizard.

        • 3 TODOs in the UI test with cases to be implemented.
        • Reusing an existing instance can be done in the UI but doesn't seem to work.
        • Reusing an existing instance should display modules from that instance on the Add and Remove (modules) page of the wizard.
        • Reusing an existing instance from a different tc Server runtime should work. E.g. I have two tc Servers in my STS, 2.7.2 and 2.8. Selecting an instance from 2.7.2 while creating a server for 2.8.0 should work fine.

        Any comments on the last three -s would be appreciated.

        Show
        Tomasz Zarna added a comment - Here is a work-in-progress commit: + Allow to select an external location for a newly create instance (uncheck Use default instance location on the Create tc Server Instance page). + Added UI test for the New Server Wizard . + Added a simple test called TcServerInstanceTest for executing instance creating with a instance dir provided. +/- No validation of a created server (e.g. if it runs) in the UI test. All assertions are about the wizard. 3 TODOs in the UI test with cases to be implemented. Reusing an existing instance can be done in the UI but doesn't seem to work. Reusing an existing instance should display modules from that instance on the Add and Remove (modules) page of the wizard. Reusing an existing instance from a different tc Server runtime should work. E.g. I have two tc Servers in my STS, 2.7.2 and 2.8. Selecting an instance from 2.7.2 while creating a server for 2.8.0 should work fine. Any comments on the last three -s would be appreciated.
        Hide
        Martin Lippert (c) added a comment -

        Hey Tomasz! Here are my comments with regards to your three questions:

        • Reusing an existing instance can be done in the UI but doesn't seem to work <= that should work and I saw this working. What exactly is not working?
        • Reusing an existing instance should display modules from that instance on the Add and Remove (modules) page of the wizard. <= the question here is how to find out which modules from your workspace are deployed in that instance, I guess. But it would be nice indeed.
        • Reusing an existing instance from a different tc Server runtime should work. E.g. I have two tc Servers in my STS, 2.7.2 and 2.8. Selecting an instance from 2.7.2 while creating a server for 2.8.0 should work fine. <= I am not sure regarding this one. I thought a tc server instance is specific for a certain tc server runtime. But if it is possible to use an instance that got created with tc server 2.7.2 with a new tc server 2.8.1, that would be great.
        Show
        Martin Lippert (c) added a comment - Hey Tomasz! Here are my comments with regards to your three questions: Reusing an existing instance can be done in the UI but doesn't seem to work <= that should work and I saw this working. What exactly is not working? Reusing an existing instance should display modules from that instance on the Add and Remove (modules) page of the wizard. <= the question here is how to find out which modules from your workspace are deployed in that instance, I guess. But it would be nice indeed. Reusing an existing instance from a different tc Server runtime should work. E.g. I have two tc Servers in my STS, 2.7.2 and 2.8. Selecting an instance from 2.7.2 while creating a server for 2.8.0 should work fine. <= I am not sure regarding this one. I thought a tc server instance is specific for a certain tc server runtime. But if it is possible to use an instance that got created with tc server 2.7.2 with a new tc server 2.8.1, that would be great.
        Hide
        Tomasz Zarna added a comment -
        Show
        Tomasz Zarna added a comment - Fixed with e13934407de7ba5683c585f077e506d3835b232e .
        Hide
        Tomasz Zarna added a comment -

        3 TODOs in the UI test with cases to be implemented.

        Done.

        Reusing an existing instance can be done in the UI but doesn't seem to work <= that should work and I saw this working. What exactly is not working?

        Not sure what I meant by that, double checked it today and it worked just fine. I was able to point to an existing instance and a newly created server started just fine.

        Reusing an existing instance should display modules from that instance on the Add and Remove (modules) page of the wizard. <= the question here is how to find out which modules from your workspace are deployed in that instance, I guess. But it would be nice indeed.

        Filed STS-3084 for it.

        Reusing an existing instance from a different tc Server runtime should work. E.g. I have two tc Servers in my STS, 2.7.2 and 2.8. Selecting an instance from 2.7.2 while creating a server for 2.8.0 should work fine. <= I am not sure regarding this one. I thought a tc server instance is specific for a certain tc server runtime. But if it is possible to use an instance that got created with tc server 2.7.2 with a new tc server 2.8.1, that would be great.

        This works fine. I was able to reuse an instance from tc Server 2.7.2 in 2.8.0. I can confirm the running server was 2.8.0 but the instance/config/webapps were taken from the 2.7.2 location.

        Show
        Tomasz Zarna added a comment - 3 TODOs in the UI test with cases to be implemented. Done. Reusing an existing instance can be done in the UI but doesn't seem to work <= that should work and I saw this working. What exactly is not working? Not sure what I meant by that, double checked it today and it worked just fine. I was able to point to an existing instance and a newly created server started just fine. Reusing an existing instance should display modules from that instance on the Add and Remove (modules) page of the wizard. <= the question here is how to find out which modules from your workspace are deployed in that instance, I guess. But it would be nice indeed. Filed STS-3084 for it. Reusing an existing instance from a different tc Server runtime should work. E.g. I have two tc Servers in my STS, 2.7.2 and 2.8. Selecting an instance from 2.7.2 while creating a server for 2.8.0 should work fine. <= I am not sure regarding this one. I thought a tc server instance is specific for a certain tc server runtime. But if it is possible to use an instance that got created with tc server 2.7.2 with a new tc server 2.8.1, that would be great. This works fine. I was able to reuse an instance from tc Server 2.7.2 in 2.8.0. I can confirm the running server was 2.8.0 but the instance/config/webapps were taken from the 2.7.2 location.

          People

          • Assignee:
            Tomasz Zarna
            Reporter:
            Martin Lippert (c)
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:
              First Response Date: