Spring Tool Suite
  1. Spring Tool Suite
  2. STS-2068

push-in of Roo-generated converter methods in ApplicationConversionServiceFactoryBean doesn't move method to java source

    Details

    • Type: Bug Bug
    • Status: Resolved Resolved
    • Priority: Major Major
    • Resolution: Complete
    • Affects Version/s: 2.7.1.RELEASE, 2.8.0.M1
    • Fix Version/s: 2.8.0.M2
    • Component/s: EDITING, ROO
    • Labels:
    • Environment:

      Mac OS X 10.5.8, jdk 1.5 (build 1.5.0_30), Roo 1.2.0.BUILD-SNAPSHOT [rev 6002fca]

      Description

      When I push in a converter method from the Roogenerated ApplicationConversionServiceFactoryBean_Roo_ConversionService.aj with "Refactor -> Push-in" command the methods are not moved to the Java source file. My expectations were they were going to be moved, just like when I push-in other methods.

      I'm not sure this is so by design or from a mistake.

        Activity

        Hide
        Andrew Eisenberg (c) added a comment -

        Thanks for the response. What do you mean 'a clean restart'? At a minimum, AJDT should add some kind of marker when the crosscutting model is invalid or incomplete. The problem is going to be detecting when this occurs, but this is something that I can work on.

        Show
        Andrew Eisenberg (c) added a comment - Thanks for the response. What do you mean 'a clean restart'? At a minimum, AJDT should add some kind of marker when the crosscutting model is invalid or incomplete. The problem is going to be detecting when this occurs, but this is something that I can work on.
        Hide
        MiB added a comment -

        With "clean restart" I meant I started up STS with "-clean" on a sepratate line in "STS.ini".

        I could see some markers I think, but very few.

        How can I help you at this stage?

        Show
        MiB added a comment - With "clean restart" I meant I started up STS with "-clean" on a sepratate line in "STS.ini". I could see some markers I think, but very few. How can I help you at this stage?
        Hide
        Andrew Eisenberg (c) added a comment -

        Nothing right now. I'll have a look at this in the next day or two and see if I can detect when the model is incomplete (and then have the push in refactoring produce a fatal error).

        Show
        Andrew Eisenberg (c) added a comment - Nothing right now. I'll have a look at this in the next day or two and see if I can detect when the model is incomplete (and then have the push in refactoring produce a fatal error).
        Hide
        Andrew Eisenberg (c) added a comment -

        I committed a fix such that pushin refactoring will do more extensive conditions checking before performing.

        Now, if there are any errors in the aspect or the target type (even if they are unrelated to the ITD being pushed in). Also, it is now checking for ITDs that have no target. In either case, if an error is found the refactoring will be blocked until fixed.

        The downside is that some refactrings that would have worked in the past are now blocked. However, we are also preventing situations that would cause unexpected, subtle errors like the one that you received earlier.

        I think this fix covers the problem described in this issue, so closing. The fix will be available in the next dev build of AJDT.

        Show
        Andrew Eisenberg (c) added a comment - I committed a fix such that pushin refactoring will do more extensive conditions checking before performing. Now, if there are any errors in the aspect or the target type (even if they are unrelated to the ITD being pushed in). Also, it is now checking for ITDs that have no target. In either case, if an error is found the refactoring will be blocked until fixed. The downside is that some refactrings that would have worked in the past are now blocked. However, we are also preventing situations that would cause unexpected, subtle errors like the one that you received earlier. I think this fix covers the problem described in this issue, so closing. The fix will be available in the next dev build of AJDT.
        Hide
        MiB added a comment -

        Thanks Andrew. Springsource/Vmware is easily one of the most responsive software companies I've been bug reporting to. An inspiration.

        Show
        MiB added a comment - Thanks Andrew. Springsource/Vmware is easily one of the most responsive software companies I've been bug reporting to. An inspiration.

          People

          • Assignee:
            Andrew Eisenberg (c)
            Reporter:
            MiB
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:
              First Response Date: