Details

    • Type: Sub-task Sub-task
    • Status: Resolved Resolved
    • Priority: Major Major
    • Resolution: Complete
    • Affects Version/s: None
    • Fix Version/s: 2.8.0.M2
    • Component/s: GRAILS
    • Labels:

      Description

      When renaming a grails view, the associated action should be renamed as well.
      (The reverse should work, too, see STS-1373.)

        Activity

        Hide
        Kris De Volder (c) added a comment - - edited

        Status update.

        Done:

        • Rename participant that renames action fields in controllers
        • Groovy AST Visitor code to find and replace calls to render(...,view:"<name>") and
          redirect(...,action:"<name>")
        • Regression tests for the visitor code
        • ensure visitor called on the right controller class(es)
        • handle both method and field actions properly (for grails 2.0 where actions can be methods)
        • changes in GSP files related to view/action renaming
          handles all forms of g:link in the docs, except for the form <g:link url="[controller:..., action:...]"

        Todo:

        Show
        Kris De Volder (c) added a comment - - edited Status update. Done: Rename participant that renames action fields in controllers Groovy AST Visitor code to find and replace calls to render(...,view:"<name>") and redirect(...,action:"<name>") Regression tests for the visitor code ensure visitor called on the right controller class(es) handle both method and field actions properly (for grails 2.0 where actions can be methods) changes in GSP files related to view/action renaming handles all forms of g:link in the docs, except for the form <g:link url=" [controller:..., action:...] " Todo: GSP changes: replace <g:link url="..."> references replace $ {link ...} references changes in filters (2.0 only) related to view/action renaming reference to a controller action in a 'defaultAction' declaration (see http://www.grails.org/doc/latest/ref/Controllers/defaultAction.html ) references in URLMappings
        Hide
        Kris De Volder (c) added a comment - - edited

        Relevant info in here (summary: Grails 2.0 actions allows methods as actions in addition to fields)
        https://issuetracker.springsource.com/browse/STS-1979

        Show
        Kris De Volder (c) added a comment - - edited Relevant info in here (summary: Grails 2.0 actions allows methods as actions in addition to fields) https://issuetracker.springsource.com/browse/STS-1979
        Hide
        Kris De Volder (c) added a comment -

        Pushing back, won't be include with 2.8.0.M1.

        Show
        Kris De Volder (c) added a comment - Pushing back, won't be include with 2.8.0.M1.
        Hide
        Kris De Volder (c) added a comment -

        Relevant info: Grails 2.0 now also has a feature that allows action names/patterns in Filters.

        Show
        Kris De Volder (c) added a comment - Relevant info: Grails 2.0 now also has a feature that allows action names/patterns in Filters.
        Hide
        Kris De Volder (c) added a comment -

        Relevant info... need to look into URLMappings. These may also contain references to actions / controllers.

        Show
        Kris De Volder (c) added a comment - Relevant info... need to look into URLMappings. These may also contain references to actions / controllers.
        Hide
        Kris De Volder (c) added a comment -

        Although there is still some work todo, I'm closing this issue as "complete".

        Will open smaller Jira issues for the remaining bits of work.

        Will also update the 'status update' message in this issue to reflect the state of the issue at this time.

        Show
        Kris De Volder (c) added a comment - Although there is still some work todo, I'm closing this issue as "complete". Will open smaller Jira issues for the remaining bits of work. Will also update the 'status update' message in this issue to reflect the state of the issue at this time.

          People

          • Assignee:
            Kris De Volder (c)
            Reporter:
            Andrew Eisenberg (c)
          • Votes:
            2 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:
              First Response Date: