Bundlor
  1. Bundlor
  2. BNDLR-319

Bundlor does not update the MANIFEST.MF with an incorrectly-specified Spring-Context header

    Details

    • Type: Defect Defect
    • Status: Done Done
    • Priority: Minor Minor
    • Resolution: Complete
    • Affects Version/s: 1.0.0.M6
    • Fix Version/s: Sprint 9, 1.0.0.RC1, 1.0.0.RELEASE
    • Labels:
      None

      Description

      Found this while trying to find out why Bundlor wasn't scanning the XML files pointed to by my template.mf's Spring-Context location. (See JIRA @ https://issuetracker.springsource.com/browse/BNDLR-318).

      If I specify paths that Bundlor appears not to like, such as:

      • Spring-Context: /MODULE-INF/META-INF/company/spring/*/.xml
      • Spring-Context: classpath:MODULE-INF/META-INF/company/spring/.xml

      In this case the MANIFEST.MF is not updated at all - it appears as though Bundlor silently fails and you would not know it unless you were carefully watching that file for changes.

      This may very well be related to any header the Bundlor cares about - I did not test any others tho.

        Activity

        Hide
        Scott Hamilton added a comment -

        Little more info on this - I think this is not necessarily related to an incorrectly-specified Spring-Context, as I see this even when I use a Spring-Context that works correctly at runtime. Example:

        Spring-Context: classpath*:META-INF/company/spring/parent-beandefs/*.xml,
        META-INF/spring/*.xml

        This works @ runtime but Bundlor will no longer update the MANIFEST.MF if I have this in my template.mf file.

        Show
        Scott Hamilton added a comment - Little more info on this - I think this is not necessarily related to an incorrectly-specified Spring-Context, as I see this even when I use a Spring-Context that works correctly at runtime. Example: Spring-Context: classpath*:META-INF/company/spring/parent-beandefs/*.xml, META-INF/spring/*.xml This works @ runtime but Bundlor will no longer update the MANIFEST.MF if I have this in my template.mf file.
        Hide
        Ben Hale (c) added a comment -

        We're no longer observing Spring-Context so I'm gonna call this good.

        Show
        Ben Hale (c) added a comment - We're no longer observing Spring-Context so I'm gonna call this good.

          People

          • Assignee:
            Unassigned
            Reporter:
            Scott Hamilton
          • Votes:
            2 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:
              First Response Date:

              Time Tracking

              Estimated:
              Original Estimate - 0.5h
              0.5h
              Remaining:
              Remaining Estimate - 0h
              0h
              Logged:
              Time Spent - 1m Time Not Required
              1m